Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Testability of Queries #813

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Improved Testability of Queries #813

wants to merge 18 commits into from

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Dec 4, 2024 •
edited
Loading

Core Unlocked Package Changes

  • Fixed code coverage error for LoggerEngineDataSelector.cls upon deployment #687: Improved how records are queried & converted to the inner classes in LoggerSObjectProxy, which are used for dynamically interacting with some standard SObject types that don't exist in all orgs (Network, OmniProcess, etc.)
    • These changes improve the testability of this part of the code base, resulting in more thorough tests & improved code coverage for the core package
  • Fixed SYNCHRONOUS_DML in a test context - Integration test #457 and fixed LoggerEngineDataSelector_Tests.it_returns_cached_tag_assignment_rules assertion error #812: Changed Nebula Logger's behavior during tests so that the org's actual CMDT records are now loaded during tests
    • This provides developers with the ability to fully test their usage of Nebula Logger, including any customizations that have been made to the include CMDT records
    • Internally, Nebula Logger's own tests still only use mock CMDT records - they do not leverage the org's actual CMDT records
  • Scope creep: added access for the existing Visualforce page LogMassDelete to the permission sets LoggerAdmin, LoggerLogViewer, and LoggerEndUser
    • This page has been around for ~3 years, but the permission sets didn't explicitly provide access to the page

Async Failure Additions Plugin Changes - v1.0.3

  • Updated LogFinalizer to skip logging the async context when no error has occurred
  • Corrected some test failures caused by changes in core v4.15.2 (this release), now that the org's actual CMDT records are loaded during tests

Big Object Archiving Plugin Changes - v0.9.1

  • Corrected some test failures caused by changes in core v4.15.2 (this release), now that the org's actual CMDT records are loaded during tests

Pipeline Changes

  • Changed the pipeline to use the base scratch org for codecov.io integration, since this org will have the lowest code coverage of any of the scratch orgs
  • Added some sample CMDT records to extra-tests directory (used by the pipeline) to help validate that the org's records are correctly returned by the new query selector class
  • Upgraded several dev dependencies in package.json / regenerated package-lock.json

@jongpie jongpie added Type: Bug Something isn't working devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine tests Relates to Apex or LWC jest tests labels Dec 4, 2024
@jongpie jongpie force-pushed the feature/improved-selector-tests-and-test-coverage branch from 53161a1 to 3655fc7 Compare December 4, 2024 05:41
@jongpie jongpie had a problem deploying to Advanced Scratch Org December 4, 2024 05:44 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Event Monitoring Scratch Org December 4, 2024 05:44 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Event Monitoring Scratch Org December 4, 2024 06:18 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Advanced Scratch Org December 4, 2024 06:18 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org December 4, 2024 19:26 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Event Monitoring Scratch Org December 4, 2024 19:26 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Advanced Scratch Org December 4, 2024 19:26 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to OmniStudio Scratch Org December 4, 2024 19:38 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org December 4, 2024 19:38 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org December 4, 2024 19:45 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org December 4, 2024 20:04 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org December 4, 2024 20:16 — with GitHub Actions Inactive
@jongpie jongpie changed the title Improved selector tests and test coverage Improved query selectors + tests + test coverage Dec 5, 2024
@jongpie jongpie force-pushed the feature/improved-selector-tests-and-test-coverage branch from 2384c3d to 5520135 Compare December 10, 2024 21:32
@jongpie jongpie temporarily deployed to Base Scratch Org December 10, 2024 21:33 — with GitHub Actions Inactive
@jongpie jongpie had a problem deploying to Advanced Scratch Org December 10, 2024 21:33 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Event Monitoring Scratch Org December 10, 2024 21:34 — with GitHub Actions Failure
@jongpie jongpie changed the title Improved query selectors + tests + test coverage Improved Testability of Queries Dec 10, 2024
@jongpie jongpie temporarily deployed to OmniStudio Scratch Org December 10, 2024 21:45 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/improved-selector-tests-and-test-coverage branch from 5520135 to 607b6c1 Compare December 10, 2024 22:09
@jongpie jongpie had a problem deploying to Advanced Scratch Org December 19, 2024 22:05 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Event Monitoring Scratch Org December 19, 2024 22:05 — with GitHub Actions Error
@jongpie jongpie temporarily deployed to Base Scratch Org December 19, 2024 22:13 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Advanced Scratch Org December 19, 2024 22:13 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Event Monitoring Scratch Org December 19, 2024 22:13 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to OmniStudio Scratch Org December 19, 2024 22:26 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org December 19, 2024 22:26 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org December 19, 2024 22:31 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org December 19, 2024 22:48 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org December 19, 2024 23:03 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/improved-selector-tests-and-test-coverage branch from c2e7f74 to 51e8ff2 Compare December 20, 2024 04:55
@jongpie jongpie temporarily deployed to Base Scratch Org December 20, 2024 04:59 — with GitHub Actions Inactive
@jongpie jongpie deployed to Advanced Scratch Org December 20, 2024 04:59 — with GitHub Actions Active
@jongpie jongpie had a problem deploying to Event Monitoring Scratch Org December 20, 2024 04:59 — with GitHub Actions Failure
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (9484c4b) to head (51e8ff2).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9484c4b) and HEAD (51e8ff2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9484c4b) HEAD (51e8ff2)
Apex 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   92.73%   85.97%   -6.77%     
==========================================
  Files          75       17      -58     
  Lines        7295     1319    -5976     
  Branches      200      200              
==========================================
- Hits         6765     1134    -5631     
+ Misses        510      165     -345     
  Partials       20       20
Flag Coverage Δ
Apex ?
LWC 85.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie had a problem deploying to OmniStudio Scratch Org December 20, 2024 05:13 — with GitHub Actions Failure
@jongpie jongpie deployed to Experience Cloud Scratch Org December 20, 2024 05:19 — with GitHub Actions Active
@jongpie jongpie deployed to Event Monitoring Scratch Org December 20, 2024 05:41 — with GitHub Actions Active
@jongpie jongpie had a problem deploying to Platform Cache Scratch Org December 20, 2024 05:53 — with GitHub Actions Failure
@jongpie jongpie deployed to OmniStudio Scratch Org December 20, 2024 05:56 — with GitHub Actions Active
@jongpie jongpie had a problem deploying to Platform Cache Scratch Org December 20, 2024 06:13 — with GitHub Actions Failure
@jongpie jongpie deployed to Platform Cache Scratch Org December 20, 2024 12:58 — with GitHub Actions Active
@jongpie jongpie temporarily deployed to Base Scratch Org December 20, 2024 13:14 — with GitHub Actions Inactive
@jongpie jongpie deployed to Base Scratch Org December 20, 2024 13:26 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine tests Relates to Apex or LWC jest tests Type: Bug Something isn't working
Projects
None yet
Milestone
Version 4.16.0: Spring '25 Release
2 participants
@jongpie @actions-user